Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-5459): add durations to connection pool events #4166

Merged
merged 14 commits into from
Jul 11, 2024
Merged

feat(NODE-5459): add durations to connection pool events #4166

merged 14 commits into from
Jul 11, 2024

Conversation

aditi-khare-mongoDB
Copy link
Contributor

@aditi-khare-mongoDB aditi-khare-mongoDB commented Jul 1, 2024 •
edited
Loading

Description

Add durations to ConnectionReadyEvent, ConnectionCheckedOutEvent, ConnectionCheckOutFailedEvent.
Sync Spec Tests.

What is changing?

See release highlights.

Is there new documentation needed for these changes?

No.

What is the motivation for this change?

Spec compliance.

Release Highlight

Add duration indicating time elapsed between connection creation and when the connection is ready

ConnectionReadyEvent now has a durationMS property that represents the time between the connection creation event and when the connection ready event is fired.

Add duration indicating time elapsed between the beginning and end of a connection checkout operation

ConnectionCheckedOutEvent/ConnectionCheckFailedEvent now have a durationMS property that represents the time between checkout start and success/failure.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@aditi-khare-mongoDB aditi-khare-mongoDB marked this pull request as ready for review July 2, 2024 20:37
@baileympearson baileympearson self-requested a review July 3, 2024 16:40
@baileympearson baileympearson self-assigned this Jul 3, 2024
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jul 3, 2024
baileympearson
baileympearson requested changes Jul 3, 2024
View reviewed changes
src/cmap/connection_pool_events.ts Outdated Show resolved Hide resolved
src/cmap/connection_pool.ts Outdated Show resolved Hide resolved
src/cmap/connection_pool_events.ts Outdated Show resolved Hide resolved
baileympearson
baileympearson requested changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, otherwise LGTM

src/cmap/connection_pool.ts Outdated Show resolved Hide resolved
@nbbeeken nbbeeken self-requested a review July 9, 2024 13:38
nbbeeken
nbbeeken reviewed Jul 9, 2024
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment clean up, lgtm.

src/cmap/connection_pool_events.ts Outdated Show resolved Hide resolved
src/cmap/connection_pool_events.ts Show resolved Hide resolved
@aditi-khare-mongoDB @nbbeeken
Update src/cmap/connection_pool_events.ts
a98c29f 
Co-authored-by: Neal Beeken <neal.beeken@mongodb.com>
@baileympearson baileympearson merged commit 7295695 into main Jul 11, 2024
26 of 29 checks passed
@baileympearson baileympearson deleted the NODE-5459/add-durations-to-connection-pool-events branch July 11, 2024 15:00
@github-actions github-actions bot mentioned this pull request Jul 9, 2024
Merged
This was referenced Oct 3, 2024
Merged
Merged
Merged
Merged
Closed
@skanda890 skanda890 mentioned this pull request Oct 4, 2024
Merged
@aravindbuilt aravindbuilt mentioned this pull request Oct 4, 2024
Closed
@akanchhaS akanchhaS mentioned this pull request Oct 4, 2024
Open
@OKEAMAH OKEAMAH mentioned this pull request Oct 4, 2024
Open
@zntb zntb mentioned this pull request Oct 4, 2024
Closed
@MohammadGhajari MohammadGhajari mentioned this pull request Oct 4, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Oct 4, 2024
Open
@lryanle lryanle mentioned this pull request Oct 4, 2024
Open
@lydmoon lydmoon mentioned this pull request Oct 4, 2024
Open
@issam-seghir issam-seghir mentioned this pull request Oct 4, 2024
Open
@TartejBrothers TartejBrothers mentioned this pull request Oct 4, 2024
Merged
@visrut-at-incubyte visrut-at-incubyte mentioned this pull request Oct 4, 2024
Open
@Habibullohnuriddin Habibullohnuriddin mentioned this pull request Oct 4, 2024
Open
@IzzyDotExe IzzyDotExe mentioned this pull request Oct 4, 2024
Merged
This was referenced Oct 5, 2024
Merged
Merged
Merged
@MoaidHashem3 MoaidHashem3 mentioned this pull request Oct 5, 2024
Open
@mkusztal mkusztal mentioned this pull request Oct 5, 2024
Open
@WontonSam WontonSam mentioned this pull request Oct 5, 2024
Open
@Abhishekh669 Abhishekh669 mentioned this pull request Oct 25, 2024
Open
@aliakseikrauchanka aliakseikrauchanka mentioned this pull request Oct 25, 2024
Open
@parseplatformorg parseplatformorg mentioned this pull request Oct 26, 2024
Open
@Xcaciv Xcaciv mentioned this pull request Oct 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@baileympearson baileympearson baileympearson approved these changes

Assignees

@baileympearson baileympearson

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aditi-khare-mongoDB @nbbeeken @baileympearson